test/codegen/expect/sunflower/sunflower.txt - Issue 1050703002: Downwards closure inference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/codegen/expect/sunflower/sunflower.txt

Issue 1050703002: Downwards closure inference (Closed) Base URL: git@github.com:dart-lang/dart-dev-compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test/codegen/expect/sunflower/sunflower.js ('K') | « test/codegen/expect/sunflower/sunflower.js ('k') | test/dart_codegen/expect/collection/linked_list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/codegen/expect/sunflower/sunflower.txt

diff --git a/test/codegen/expect/sunflower/sunflower.txt b/test/codegen/expect/sunflower/sunflower.txt

index 39c62ced783622cdcc9971e5402cf290e2c01a9c..58bf3f151b7b7accd391f0d2b51cccb4c15c0a3b 100644

--- a/test/codegen/expect/sunflower/sunflower.txt

+++ b/test/codegen/expect/sunflower/sunflower.txt

@@ -5,6 +5,6 @@ final InputElement slider = querySelector("#slider");

info: line 26, column 5 of test/codegen/sunflower/sunflower.dart: [AssignmentCast] (querySelector("#canvas") as CanvasElement).getContext('2d') (RenderingContext) will need runtime check to cast to type CanvasRenderingContext2D

(querySelector("#canvas") as CanvasElement).getContext('2d');

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

-warning: line 29, column 37 of test/codegen/sunflower/sunflower.dart: [ClosureWrapLiteral] (e) => draw() ((dynamic) → void) will need to be wrapped with a closure of type (Event) → void

+info: line 29, column 37 of test/codegen/sunflower/sunflower.dart: [InferredTypeClosure] (e) => draw() has inferred type (Event) → void

slider.addEventListener('change', (e) => draw());

^^^^^^^^^^^^^