test/codegen/expect/sunflower/sunflower.txt - Issue 1050703002: Downwards closure inference

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/codegen/expect/sunflower/sunflower.txt

Issue 1050703002: Downwards closure inference (Closed) Base URL: git@github.com:dart-lang/dart-dev-compiler.git@master

Patch Set: Address comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Messages from compiling sunflower.html	1 // Messages from compiling sunflower.html

2 info: line 21, column 29 of test/codegen/sunflower/sunflower.dart: [AssignmentCa st] querySelector("#slider") (Element) will need runtime check to cast to type I nputElement	2 info: line 21, column 29 of test/codegen/sunflower/sunflower.dart: [AssignmentCa st] querySelector("#slider") (Element) will need runtime check to cast to type I nputElement

3 final InputElement slider = querySelector("#slider");	3 final InputElement slider = querySelector("#slider");

4 ^^^^^^^^^^^^^^^^^^^^^^^^	4 ^^^^^^^^^^^^^^^^^^^^^^^^

5 info: line 26, column 5 of test/codegen/sunflower/sunflower.dart: [AssignmentCas t] (querySelector("#canvas") as CanvasElement).getContext('2d') (RenderingContex t) will need runtime check to cast to type CanvasRenderingContext2D	5 info: line 26, column 5 of test/codegen/sunflower/sunflower.dart: [AssignmentCas t] (querySelector("#canvas") as CanvasElement).getContext('2d') (RenderingContex t) will need runtime check to cast to type CanvasRenderingContext2D

6 (querySelector("#canvas") as CanvasElement).getContext('2d');	6 (querySelector("#canvas") as CanvasElement).getContext('2d');

7 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^	7 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

8 warning: line 29, column 37 of test/codegen/sunflower/sunflower.dart: [ClosureWr apLiteral] (e) => draw() ((dynamic) → void) will need to be wrapped with a closu re of type (Event) → void	8 info: line 29, column 37 of test/codegen/sunflower/sunflower.dart: [InferredType Closure] (e) => draw() has inferred type (Event) → void

9 slider.addEventListener('change', (e) => draw());	9 slider.addEventListener('change', (e) => draw());

10 ^^^^^^^^^^^^^	10 ^^^^^^^^^^^^^

OLD	NEW

« no previous file with comments | « test/codegen/expect/sunflower/sunflower.js ('k') | test/dart_codegen/expect/collection/linked_list.dart » ('j') | no next file with comments »