Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1050633002: Revert of BitmapTextBatch and BitmapTextBlob (Closed)

Created:
5 years, 8 months ago by joshualitt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@dfpr_take_2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of BitmapTextBatch and BitmapTextBlob (patchset #18 id:360001 of https://codereview.chromium.org/1011403004/) Reason for revert: Breaks a unit test on mac Original issue's description: > BitmapTextBatch and BitmapTextBlob > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/eed1dae04932483579b02c10f0706127d3f5d984 TBR=fmalita@chromium.org,reed@google.com,jvanverth@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@chromium.org,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c03391e792a55219ddcb033475dc6b80e6a3e2f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1605 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkTextBlob.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrBatchAtlas.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
D src/gpu/GrBatchFontCache.h View 1 chunk +0 lines, -137 lines 0 comments Download
D src/gpu/GrBatchFontCache.cpp View 1 chunk +0 lines, -309 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +0 lines, -121 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 7 chunks +19 lines, -940 lines 0 comments Download
M src/gpu/GrContext.cpp View 7 chunks +0 lines, -14 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrFontAtlasSizes.h View 2 chunks +1 line, -25 lines 0 comments Download
M src/gpu/GrGlyph.h View 2 chunks +6 lines, -10 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrTextContext.h View 3 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of BitmapTextBatch and BitmapTextBlob
5 years, 8 months ago (2015-03-31 18:32:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050633002/1
5 years, 8 months ago (2015-03-31 18:32:45 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 18:33:12 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c03391e792a55219ddcb033475dc6b80e6a3e2f9

Powered by Google App Engine
This is Rietveld 408576698