Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: shell/app_child_process_host.h

Issue 1050613002: Shell: Remove ChildProcessHost::Delegate. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | shell/app_child_process_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SHELL_APP_CHILD_PROCESS_HOST_H_ 5 #ifndef SHELL_APP_CHILD_PROCESS_HOST_H_
6 #define SHELL_APP_CHILD_PROCESS_HOST_H_ 6 #define SHELL_APP_CHILD_PROCESS_HOST_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "mojo/edk/embedder/channel_info_forward.h" 11 #include "mojo/edk/embedder/channel_info_forward.h"
12 #include "shell/app_child_process.mojom.h" 12 #include "shell/app_child_process.mojom.h"
13 #include "shell/child_process_host.h" 13 #include "shell/child_process_host.h"
14 14
15 namespace mojo { 15 namespace mojo {
16 namespace shell { 16 namespace shell {
17 17
18 // A subclass of |ChildProcessHost| to host an app child process, which runs a 18 // A subclass of |ChildProcessHost| to host an app child process, which runs a
19 // single app (loaded from the file system). 19 // single app (loaded from the file system).
20 // 20 //
21 // Note: After |Start()|, |StartApp| must be called and this object must 21 // Note: After |Start()|, |StartApp| must be called and this object must
22 // remained alive until the |on_app_complete| callback is called. 22 // remained alive until the |on_app_complete| callback is called.
23 class AppChildProcessHost : public ChildProcessHost, 23 class AppChildProcessHost : public ChildProcessHost {
24 public ChildProcessHost::Delegate {
25 public: 24 public:
26 explicit AppChildProcessHost(Context* context); 25 explicit AppChildProcessHost(Context* context);
27 ~AppChildProcessHost() override; 26 ~AppChildProcessHost() override;
28 27
29 // See |AppChildController|: 28 // See |AppChildController|:
30 void StartApp(const String& app_path, 29 void StartApp(const String& app_path,
31 bool clean_app_path, 30 bool clean_app_path,
32 InterfaceRequest<Application> application_request, 31 InterfaceRequest<Application> application_request,
33 const AppChildController::StartAppCallback& on_app_complete); 32 const AppChildController::StartAppCallback& on_app_complete);
34 void ExitNow(int32_t exit_code); 33 void ExitNow(int32_t exit_code);
35 34
36 // |ChildProcessHost::Delegate| methods: 35 // |ChildProcessHost| methods:
37 void WillStart() override; 36 void WillStart() override;
38 void DidStart(bool success) override; 37 void DidStart(bool success) override;
39 38
40 private: 39 private:
41 // Callback for |embedder::CreateChannel()|. 40 // Callback for |embedder::CreateChannel()|.
42 void DidCreateChannel(embedder::ChannelInfo* channel_info); 41 void DidCreateChannel(embedder::ChannelInfo* channel_info);
43 42
44 void AppCompleted(int32_t result); 43 void AppCompleted(int32_t result);
45 44
46 AppChildControllerPtr controller_; 45 AppChildControllerPtr controller_;
47 embedder::ChannelInfo* channel_info_; 46 embedder::ChannelInfo* channel_info_;
48 AppChildController::StartAppCallback on_app_complete_; 47 AppChildController::StartAppCallback on_app_complete_;
49 48
50 DISALLOW_COPY_AND_ASSIGN(AppChildProcessHost); 49 DISALLOW_COPY_AND_ASSIGN(AppChildProcessHost);
51 }; 50 };
52 51
53 } // namespace shell 52 } // namespace shell
54 } // namespace mojo 53 } // namespace mojo
55 54
56 #endif // SHELL_APP_CHILD_PROCESS_HOST_H_ 55 #endif // SHELL_APP_CHILD_PROCESS_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | shell/app_child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698