Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issue 1050493002: Put newspace evacuation in an EvacuationScope (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put newspace evacuation in an EvacuationScope BUG=chromium:471554 LOG=y R=hpayer@chromium.org Committed: https://crrev.com/a5522eaff785789eaf6d1fbefc9c4056056331c8 Cr-Commit-Position: refs/heads/master@{#27539}

Patch Set 1 #

Patch Set 2 : Verify after evacuation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/heap/mark-compact.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 8 months ago (2015-03-31 12:35:45 UTC) #1
Hannes Payer (out of office)
LGTM, thx!
5 years, 8 months ago (2015-03-31 12:47:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050493002/20001
5 years, 8 months ago (2015-03-31 12:57:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 13:18:08 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a5522eaff785789eaf6d1fbefc9c4056056331c8 Cr-Commit-Position: refs/heads/master@{#27539}
5 years, 8 months ago (2015-03-31 13:18:16 UTC) #6
Michael Achenbach
5 years, 8 months ago (2015-03-31 15:19:47 UTC) #8
Message was sent while issue was closed.
Can that have caused the gcstress failures on arm64?
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...

Powered by Google App Engine
This is Rietveld 408576698