pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart - Issue 1050483002: fix NSM error when completing imported inherited private fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 1050483002: fix NSM error when completing imported inherited private fields (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_computer.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

index 20cacc77ecbc6c63b556c7e7ba643e5c3dd6d976..8a910afede57c94d4461e280008fb639fe39f600 100644

--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

@@ -180,7 +180,11 @@ abstract class ElementSuggestionBuilder {

void addSuggestion(Element element, {int relevance: DART_RELEVANCE_DEFAULT}) {

if (element.isPrivate) {

LibraryElement elementLibrary = element.library;

- LibraryElement unitLibrary = request.unit.element.library;

+ CompilationUnitElement unitElem = request.unit.element;

+ if (unitElem == null) {

+ return;

+ }

+ LibraryElement unitLibrary = unitElem.library;

if (elementLibrary != unitLibrary) {

return;

}