Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1050443002: Turn off overapproximation of the weak closure again (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn off overapproximation of the weak closure again As long as we still have to process global handles, the impact is not yet worthwhile BUG=v8:3862 R=hpayer@chromium.org LOG=y Committed: https://crrev.com/294cdc6aecbd7f76be68217da4b3d35901ebce4b Cr-Commit-Position: refs/heads/master@{#27570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-03-31 10:11:29 UTC) #1
Hannes Payer (out of office)
ok, lgtm
5 years, 8 months ago (2015-04-01 08:38:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050443002/1
5 years, 8 months ago (2015-04-01 16:18:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 16:52:24 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/294cdc6aecbd7f76be68217da4b3d35901ebce4b Cr-Commit-Position: refs/heads/master@{#27570}
5 years, 8 months ago (2015-04-01 16:52:40 UTC) #6
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-07 09:45:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1068723003/ by jochen@chromium.org.

The reason for reverting is: this indeed drops the max major gc time
considerable, so turn it back on.

Powered by Google App Engine
This is Rietveld 408576698