Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 1050433002: ARM simulator needs a StackCheck in GetPropertyWithDefinedGetter. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM simulator needs a StackCheck in GetPropertyWithDefinedGetter. Because simulators have a seperate JavaScript and C++ stack, and because they try to avoid calling the runtime StackCheck function on entry to every function, it can happen in recursive calls that the C++ stack overflows while the JavaScript stack is okay. The runtime StackCheck function would catch this, but as an optimization, generated code only looks at the JavaScript stack pointer to determine if it should make that runtime call. R=ulan@chromium.org BUG= Committed: https://crrev.com/9c3f53d7082251368dbeddb7c50e2da15422b122 Cr-Commit-Position: refs/heads/master@{#27533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Ulan, PTAL, thanks for the help! --Michael
5 years, 8 months ago (2015-03-31 06:26:36 UTC) #1
ulan
lgtm
5 years, 8 months ago (2015-03-31 08:46:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050433002/1
5 years, 8 months ago (2015-03-31 09:55:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 10:37:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 10:38:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c3f53d7082251368dbeddb7c50e2da15422b122
Cr-Commit-Position: refs/heads/master@{#27533}

Powered by Google App Engine
This is Rietveld 408576698