Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1050403004: Attempt to deflake append-child-adopt-node-error-crash.html test. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
falken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Attempt to deflake append-child-adopt-node-error-crash.html test. Somewhat speculative, avoid potential timing issues with iframe loads going ahead before the test has initialized fully. R= BUG=474155 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-error-crash.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-error-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a (quick) look? tia.
5 years, 8 months ago (2015-04-06 18:00:11 UTC) #2
falken
lgtm
5 years, 8 months ago (2015-04-07 01:24:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050403004/1
5 years, 8 months ago (2015-04-07 01:24:16 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 01:27:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193232

Powered by Google App Engine
This is Rietveld 408576698