snapshot/mac/process_snapshot_mac.h - Issue 1050313003: Handle EXC_RESOURCE and EXC_GUARD exceptions properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/process_snapshot_mac.h

Issue 1050313003: Handle EXC_RESOURCE and EXC_GUARD exceptions properly (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Better logging Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/mac/process_snapshot_mac.h

diff --git a/snapshot/mac/process_snapshot_mac.h b/snapshot/mac/process_snapshot_mac.h

index 7221d2cf67d27495247ac85177a04b2d40054cd5..06f2fd9988dae0d1400f624576c1a28819a02403 100644

--- a/snapshot/mac/process_snapshot_mac.h

+++ b/snapshot/mac/process_snapshot_mac.h

@@ -69,7 +69,8 @@ class ProcessSnapshotMac final : public ProcessSnapshot {

//! \return `true` if the exception information could be initialized, `false`

//! otherwise with an appropriate message logged. When this method returns

//! `false`, the ProcessSnapshotMac object’s validity remains unchanged.

- bool InitializeException(thread_t exception_thread,

+ bool InitializeException(exception_behavior_t behavior,

+ thread_t exception_thread,

exception_type_t exception,

const mach_exception_data_type_t* code,

mach_msg_type_number_t code_count,

« no previous file with comments | « snapshot/mac/exception_snapshot_mac.cc ('k') | snapshot/mac/process_snapshot_mac.cc » ('j') | no next file with comments »