Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: snapshot/exception_snapshot.h

Issue 1050313003: Handle EXC_RESOURCE and EXC_GUARD exceptions properly (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Better logging Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | snapshot/mac/exception_snapshot_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/exception_snapshot.h
diff --git a/snapshot/exception_snapshot.h b/snapshot/exception_snapshot.h
index 20598332bcfd189d4cf6a197b84425b8f6dd49c9..f5ffd06a2295a9991a85143449c14d5ce4f77b04 100644
--- a/snapshot/exception_snapshot.h
+++ b/snapshot/exception_snapshot.h
@@ -60,10 +60,15 @@ class ExceptionSnapshot {
//! This is an operating system-specific value.
//!
//! For Mac OS X, this will be the value of the exception code at index 0 as
- //! received by a Mach exception handler. For `EXC_CRASH` exceptions generated
- //! from another preceding exception, the original exception code will appear
- //! here, not the code as received by the Mach exception handler. The code as
- //! it was received will appear at index 1 of Codes().
+ //! received by a Mach exception handler, except:
+ //! * For `EXC_CRASH` exceptions generated from another preceding exception,
+ //! the original exception code will appear here, not the code as received
+ //! by the Mach exception handler.
+ //! * For `EXC_RESOURCE` and `EXC_GUARD` exceptions, the high 32 bits of the
+ //! exception code at index 0 will appear here.
+ //!
+ //! In all cases on Mac OS X, the full exception code at index 0 as it was
+ //! received will appear at index 1 of Codes().
virtual uint32_t ExceptionInfo() const = 0;
//! \brief Returns the address that triggered the exception.
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | snapshot/mac/exception_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698