buildbot/buildbot_lib.py - Issue 1050243003: Don't try to chmod symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: buildbot/buildbot_lib.py

Issue 1050243003: Don't try to chmod symlinks. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: buildbot/buildbot_lib.py

diff --git a/buildbot/buildbot_lib.py b/buildbot/buildbot_lib.py

index 2c54d8225651c375df877d60f6492bf8fb6582f4..26aa924914c64c25a3bfc93b30849332e60014e2 100644

--- a/buildbot/buildbot_lib.py

+++ b/buildbot/buildbot_lib.py

@@ -359,7 +359,8 @@ def RemovePath(path):

if os.path.isdir(path):

RemoveDirectory(path)

else:

- os.chmod(path, stat.S_IWUSR)

+ if os.path.isfile(path) and not os.access(path, os.W_OK):

+ os.chmod(path, stat.S_IWUSR)

os.remove(path)

« no previous file with comments | « no previous file | no next file » | no next file with comments »