Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1050233005: Make a mojo:apptests GN meta-target, add apptests. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a mojo:apptests GN meta-target, add apptests. Add an apptest meta-target in mojo/BUILD.gn. Move the apptests targets specified in src/BUILD.gn. Add the remaining apptest targets (clipboard, VM, WM). Was limited to release, allow debug, but exclude component. See gn_debug compile error from including component build in PS2: FAILED: /b/build/slave/linux_chromium_gn/build/src/buildtools/linux64/gn --root=/b/build/slave/linux_chromium_gn/build/src -q gen //out/Debug/ ERROR at //mojo/shell/BUILD.gn:13:1: Assertion failed. assert(!is_component_build) BUG=NONE TEST=Building mojo:apptests builds all local apptest binaries (on dbg too!). R=sky@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/16b112790f541670d5f2ab97dfa70c8b89b44b1f Cr-Commit-Position: refs/heads/master@{#325570}

Patch Set 1 #

Patch Set 2 : Allow apptest targets in component builds. #

Patch Set 3 : Revert allowing apptests on component builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -6 lines 0 comments Download
M mojo/BUILD.gn View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 8 months ago (2015-04-16 20:25:05 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-16 20:26:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050233005/60001
5 years, 8 months ago (2015-04-16 20:39:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56941)
5 years, 8 months ago (2015-04-16 20:56:20 UTC) #7
msw
Ben, take a look for OWNERS as you have time; landing.
5 years, 8 months ago (2015-04-16 21:00:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050233005/60001
5 years, 8 months ago (2015-04-16 21:00:59 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-04-17 00:45:41 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/16b112790f541670d5f2ab97dfa70c8b89b44b1f Cr-Commit-Position: refs/heads/master@{#325570}
5 years, 8 months ago (2015-04-17 00:46:37 UTC) #13
msw
5 years, 8 months ago (2015-04-17 01:51:06 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1093763002/ by msw@chromium.org.

The reason for reverting is: Caused compile failures (many errors, one example
below) on Mac GN bot:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/7019/steps/...

gen/mojo/services/html_viewer/blink_resource_map.h:37:58:error: no newline at
end of file [-Werror,-Wnewline-eof]
#endif // MOJO_SERVICES_HTML_VIEWER_BLINK_RESOURCE_MAP_H_.

Powered by Google App Engine
This is Rietveld 408576698