Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3237)

Unified Diff: base/trace_event/java_heap_dump_provider_android.h

Issue 1050233004: Adding dump provider for dumping java heap sizes on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/java_heap_dump_provider_android.h
diff --git a/base/trace_event/malloc_dump_provider.h b/base/trace_event/java_heap_dump_provider_android.h
similarity index 52%
copy from base/trace_event/malloc_dump_provider.h
copy to base/trace_event/java_heap_dump_provider_android.h
index b6f697363a0080fb121d8725a6085160bb456f48..21de5dfedd82297115cd15e82cb2a13f1dfd8e56 100644
--- a/base/trace_event/malloc_dump_provider.h
+++ b/base/trace_event/java_heap_dump_provider_android.h
@@ -2,10 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef BASE_TRACE_EVENT_MALLOC_DUMP_PROVIDER_H_
-#define BASE_TRACE_EVENT_MALLOC_DUMP_PROVIDER_H_
-
-#include <istream>
+#ifndef BASE_TRACE_EVENT_JAVA_HEAP_DUMP_PROVIDER_ANDROID_H_
+#define BASE_TRACE_EVENT_JAVA_HEAP_DUMP_PROVIDER_ANDROID_H_
#include "base/memory/singleton.h"
#include "base/trace_event/memory_dump_provider.h"
@@ -14,24 +12,24 @@ namespace base {
namespace trace_event {
// Dump provider which collects process-wide memory stats.
-class BASE_EXPORT MallocDumpProvider : public MemoryDumpProvider {
+class BASE_EXPORT AndrdoiJavaHeapDumpProvider : public MemoryDumpProvider {
Primiano Tucci (use gerrit) 2015/04/21 18:36:01 Nit: you miss a "d" here (Androi).
Primiano Tucci (use gerrit) 2015/04/21 18:36:01 This doesn't need to be BASE_EXPORT-ed. It's inter
ssid 2015/04/22 10:40:11 Actually i have the d in middle :P. changed to Jav
ssid 2015/04/22 10:40:11 Done.
public:
- static MallocDumpProvider* GetInstance();
+ static AndrdoiJavaHeapDumpProvider* GetInstance();
// MemoryDumpProvider implementation.
bool DumpInto(ProcessMemoryDump* pmd) override;
const char* GetFriendlyName() const override;
private:
- friend struct DefaultSingletonTraits<MallocDumpProvider>;
+ friend struct DefaultSingletonTraits<AndrdoiJavaHeapDumpProvider>;
- MallocDumpProvider();
- ~MallocDumpProvider() override;
+ AndrdoiJavaHeapDumpProvider();
+ ~AndrdoiJavaHeapDumpProvider() override;
- DISALLOW_COPY_AND_ASSIGN(MallocDumpProvider);
+ DISALLOW_COPY_AND_ASSIGN(AndrdoiJavaHeapDumpProvider);
};
} // namespace trace_event
} // namespace base
-#endif // BASE_TRACE_EVENT_MALLOC_DUMP_PROVIDER_H_
+#endif // BASE_TRACE_EVENT_JAVA_HEAP_DUMP_PROVIDER_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698