Begin making copies of AST nodes for constants during resolution.

pkg/analyzer/test/generated/all_the_rest_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.all_the_rest_test;
 
 import 'dart:collection';
@@ skipping 913 matching lines @@
 
   List<InstanceCreationExpression> _findConstructorInvocations() {
     ConstantFinder finder = new ConstantFinder();
     _node.accept(finder);
     List<InstanceCreationExpression> constructorInvocations =
         finder.constructorInvocations;
     expect(constructorInvocations, isNotNull);
     return constructorInvocations;
   }
 
-  Map<VariableElement, VariableDeclaration> _findVariableDeclarations() {
+  Map<PotentiallyConstVariableElement, VariableDeclaration> _findVariableDeclarations() {
     ConstantFinder finder = new ConstantFinder();
     _node.accept(finder);
-    Map<VariableElement, VariableDeclaration> variableMap = finder.variableMap;
+    Map<PotentiallyConstVariableElement, VariableDeclaration> variableMap =
+        finder.variableMap;
     expect(variableMap, isNotNull);
     return variableMap;
   }
 
   ConstructorElement _setupConstructorDeclaration(String name, bool isConst) {
     Keyword constKeyword = isConst ? Keyword.CONST : null;
     ConstructorDeclaration constructorDeclaration = AstFactory
         .constructorDeclaration2(constKeyword, null, null, name,
             AstFactory.formalParameterList(), null,
             AstFactory.blockFunctionBody2());
@@ skipping 6893 matching lines @@
   @override
   SdkLibrary getSdkLibrary(String dartUri) => null;
 
   @override
   Source mapDartUri(String dartUri) => null;
 }
 
 @reflectiveTest
 class ReferenceFinderTest extends EngineTestCase {
   DirectedGraph<AstNode> _referenceGraph;
-  Map<VariableElement, VariableDeclaration> _variableDeclarationMap;
+  Map<PotentiallyConstVariableElement, VariableDeclaration> _variableDeclarationMap;
   Map<ConstructorElement, ConstructorDeclaration> _constructorDeclarationMap;
   VariableDeclaration _head;
   AstNode _tail;
   @override
   void setUp() {
     _referenceGraph = new DirectedGraph<AstNode>();
     _variableDeclarationMap =
-        new HashMap<VariableElement, VariableDeclaration>();
+        new HashMap<PotentiallyConstVariableElement, VariableDeclaration>();
     _constructorDeclarationMap =
         new HashMap<ConstructorElement, ConstructorDeclaration>();
     _head = AstFactory.variableDeclaration("v1");
   }
   void test_visitInstanceCreationExpression_const() {
     _visitNode(_makeTailConstructor("A", true, true, true));
     _assertOneArc(_tail);
   }
   void test_visitInstanceCreationExpression_nonConstDeclaration() {
     // In the source:
@@ skipping 102 matching lines @@
     if (inMap) {
       _constructorDeclarationMap[constructorElement] = constructorDeclaration;
     }
     superConstructorInvocation.staticElement = constructorElement;
     return superConstructorInvocation;
   }
   SimpleIdentifier _makeTailVariable(String name, bool isConst, bool inMap) {
     VariableDeclaration variableDeclaration =
         AstFactory.variableDeclaration(name);
     _tail = variableDeclaration;
-    VariableElementImpl variableElement =
-        ElementFactory.localVariableElement2(name);
+    ConstLocalVariableElementImpl variableElement =
+        ElementFactory.constLocalVariableElement(name);
     variableElement.const3 = isConst;
     AstFactory.variableDeclarationList2(
         isConst ? Keyword.CONST : Keyword.VAR, [variableDeclaration]);
     if (inMap) {
       _variableDeclarationMap[variableElement] = variableDeclaration;
     }
     SimpleIdentifier identifier = AstFactory.identifier3(name);
     identifier.staticElement = variableElement;
     return identifier;
   }
@@ skipping 626 matching lines @@
     if (_expectedExternalScriptName == null) {
       expect(scriptSource, isNull, reason: "script $scriptIndex");
     } else {
       expect(scriptSource, isNotNull, reason: "script $scriptIndex");
       String actualExternalScriptName = scriptSource.shortName;
       expect(actualExternalScriptName, _expectedExternalScriptName,
           reason: "script $scriptIndex");
     }
   }
 }