Begin making copies of AST nodes for constants during resolution.

pkg/analyzer/lib/src/generated/ast.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.ast;
 
 import 'dart:collection';
@@ skipping 5291 matching lines @@
       //      VariableElement variable = (VariableElement) element;
       //      if (variable.isStatic() && variable.isConst()) {
       //        //variable.getConstantValue();
       //      }
     }
     return NOT_A_CONSTANT;
   }
 }
 
 /**
+ * Object representing a "const" instance creation expression, and its
+ * evaluation result.  This is used as the target for constant evaluation of
+ * instance creation expressions.
+ */
+class ConstantInstanceCreationHandle {

[Brian Wilkerson, 2015/04/01 20:31:54]

Do you mean "target" as in AnalysisTarget? If so, this class should implement
AnalysisTarget (but it's fine if you want to do that in a later step).

[Paul Berry, 2015/04/02 15:18:49]

Yes, that was what I meant.  I've changed the comment to say AnalysisTarget to
be clearer.  I'll add the "implements" clause in a future CL.

+  /**
+   * The result of evaluating the constant.
+   */
+  EvaluationResultImpl evaluationResult;
+}
+
+/**
  * A constructor declaration.
  *
  * > constructorDeclaration ::=
  * >     constructorSignature [FunctionBody]?
  * >   | constructorName formalParameterList ':' 'this' ('.' [SimpleIdentifier])? arguments
  * >
  * > constructorSignature ::=
  * >     'external'? constructorName formalParameterList initializerList?
  * >   | 'external'? 'factory' factoryName formalParameterList initializerList?
  * >   | 'external'? 'const'  constructorName formalParameterList initializerList?
@@ skipping 5296 matching lines @@
   ArgumentList _argumentList;
 
   /**
    * The element associated with the constructor based on static type
    * information, or `null` if the AST structure has not been resolved or if the
    * constructor could not be resolved.
    */
   ConstructorElement staticElement;
 
   /**
-   * The result of evaluating this expression, if it is constant.
+   * The [ConstantInstanceCreationHandle] holding the result of evaluating this
+   * expression, if it is constant.
    */
-  EvaluationResultImpl evaluationResult;
+  ConstantInstanceCreationHandle constantHandle;
 
   /**
    * Initialize a newly created instance creation expression.
    */
   InstanceCreationExpression(this.keyword, ConstructorName constructorName,
       ArgumentList argumentList) {
     _constructorName = _becomeParentOf(constructorName);
     _argumentList = _becomeParentOf(argumentList);
   }
 
@@ skipping 27 matching lines @@
    * Set the name of the constructor to be invoked to the given [name].
    */
   void set constructorName(ConstructorName name) {
     _constructorName = _becomeParentOf(name);
   }
 
   @override
   Token get endToken => _argumentList.endToken;
 
   /**
+   * The result of evaluating this expression, if it is constant.
+   */
+  EvaluationResultImpl get evaluationResult {
+    if (constantHandle != null) {
+      return constantHandle.evaluationResult;
+    }
+    return null;
+  }
+
+  /**
    * Return `true` if this creation expression is used to invoke a constant
    * constructor.
    */
   bool get isConst => keyword is KeywordToken &&
       (keyword as KeywordToken).keyword == Keyword.CONST;
 
   @override
   int get precedence => 16;
 
   @override
@@ skipping 9434 matching lines @@
   }
 
   @override
   accept(AstVisitor visitor) => visitor.visitYieldStatement(this);
 
   @override
   void visitChildren(AstVisitor visitor) {
     _safelyVisitChild(_expression, visitor);
   }
 }