Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/libpng/README.google

Issue 1050183002: Revert of Enable both static and dynamically linked libpng (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 URL: http://www.libpng.org/pub/png/libpng.html 1 URL: http://www.libpng.org/pub/png/libpng.html
2 Version: 1.6.16 2 Version: 1.6.16
3 License: libpng license 3 License: libpng license
4 License File: LICENSE, pulled out of png.h 4 License File: LICENSE, pulled out of png.h
5 Description: png compression/decompression library 5 Description: png compression/decompression library
6 Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a 6 Local Modifications: Created pnglibconf.h from pnglibconf.h.prebuilt (just a
7 rename with a few additional settings enabled). (2) Created pngprefix.h 7 rename). Pulled LICENSE into its own file.
8 that is required when using the PNG_PREFIX define. (3) Pulled LICENSE into
9 its own file.
10 8
11 FAQ: 9 FAQ:
12 Q: Why does this directory exist? 10 Q: Why does this directory exist?
13 A: libpng is pulled in through DEPS, but in order to build it using ninja, we 11 A: libpng is pulled in through DEPS, but in order to build it using ninja, we
14 need to create pnglibconf.h and pngprefix.h. We originally tried creating 12 need to create pnglibconf.h. In https://codereview.chromium.org/930283002/,
15 the file as an action in https://codereview.chromium.org/930283002/, but this 13 we originally tried creating the file as an action, but this apparently led
16 apparently led to a race condition on Windows, where some builds failed to 14 to a race condition on Windows, where some builds failed to create the file
17 create the file in time for other files to include it. By checking these 15 in time for other files to include it. By checking pnglibconf.h directly
18 files directly into Skia, we eliminate the race condition. 16 into Skia, we eliminate the race condition.
OLDNEW
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698