Issue 1050183002: Revert of Enable both static and dynamically linked libpng

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050183002: Revert of Enable both static and dynamically linked libpng (Closed)

Created:
5 years, 8 months ago by djsollen

Modified:
5 years, 8 months ago

Reviewers:
msarett, scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Enable both static and dynamically linked libpng (patchset #4 id:60001 of https://codereview.chromium.org/1032253003/) Reason for revert: breaking the nexus_9 and ios builds. Original issue's description: > Enable both static and dynamically linked libpng > > All platforms except android are configured to use the statically linked copy of libpng. Android uses the system provided dynamic copy for SkImageDecoder and the static copy for SkCodec. The exception being android framework builds that currently use the dynamic copy everywhere. > > This CL also enables NEON optimizations for libpng. > > Committed: https://skia.googlesource.com/skia/+/2469c999518e7b0063d35e9e2eb074a0477c21ac TBR=scroggo@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1865900525b6c6df19824813c0d3222ad6a90da2

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -556 lines)			Patch
M	gyp/codec.gyp	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	gyp/common_variables.gypi	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	gyp/libpng.gyp	View	1 chunk	+74 lines, -68 lines	0 comments	Download
M	src/codec/SkCodec_libpng.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	third_party/libpng/README.google	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	third_party/libpng/pnglibconf.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	third_party/libpng/pngprefix.h	View	1 chunk	+0 lines, -447 lines	0 comments	Download

Total messages: 3 (0 generated)

djsollen

Created Revert of Enable both static and dynamically linked libpng

5 years, 8 months ago (2015-04-01 18:19:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050183002/1

5 years, 8 months ago (2015-04-01 18:19:59 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 18:20:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1865900525b6c6df19824813c0d3222ad6a90da2