chrome/android/java/res/layout/contextual_search_opt_out_promo.xml - Issue 1050163004: [Contextual Search] Implements Opt-out promo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/contextual_search_opt_out_promo.xml

Issue 1050163004: [Contextual Search] Implements Opt-out promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/contextual_search_view.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.widget.ContextualSearchOptOutPromo

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	9 android:id="@+id/contextual_search_opt_out_promo"

	10 android:layout_width="match_parent"

	11 android:layout_height="wrap_content"

	12 android:orientation="vertical">

	13

	14 <LinearLayout

	15 android:layout_width="match_parent"

	16 android:layout_height="wrap_content"

	17 android:layout_marginTop="9dp"

	18 android:background="#EEE"

	19 android:orientation="vertical">

	20

	21 <!-- marginTop = 16dp - 9dp (margin above) -->

	22 <org.chromium.ui.widget.TextViewWithClickableSpans

	23 android:id="@+id/contextual_search_opt_out_text"

	24 android:color="@color/contextual_search_promo_text_color"

	25 android:layout_width="match_parent"

	26 android:layout_height="wrap_content"

	27 android:layout_marginTop="7dp"

	28 android:layout_marginStart="16dp"

	29 android:layout_marginEnd="16dp"

	30 android:bufferType="spannable"

	31 android:textSize="16sp" />

	32

	33 <Button
	Donn Denman 2015/04/02 19:44:58 As you know, we'll want to add a second button. As you know, we'll want to add a second button. pedro (no code reviews) 2015/04/03 21:01:01 Acknowledged. Show quoted text On 2015/04/02 19:44:58, Donn Denman wrote: > As you know, we'll want to add a second button. Acknowledged.
	34 android:id="@+id/contextual_search_got_it_button"

	35 android:layout_width="wrap_content"

	36 android:layout_height="wrap_content"

	37 android:layout_gravity="end"

	38 android:layout_marginEnd="16dp"

	39 android:background="?attr/selectableItemBackground"

	40 android:fontFamily="sans-serif-medium"

	41 android:paddingStart="8dp"

	42 android:paddingEnd="8dp"

	43 android:text="@string/contextual_search_got_it_button"

	44 android:textAllCaps="true"

	45 android:textColor="@color/light_active_color"

	46 android:textSize="14sp" />

	47

	48 <View

	49 android:layout_width="match_parent"

	50 android:layout_height="1px"

	51 android:background="#c2c2c2" />

	52

	53 </LinearLayout>

	54 </org.chromium.chrome.browser.widget.ContextualSearchOptOutPromo>

OLD	NEW