Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1050123003: Rewrote password layout test and removed obsolete tests. (Closed)

Created:
5 years, 8 months ago by nektarios
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rewrote password layout test and removed obsolete tests. This is to make way for the deprecation of selectedTextRange and insertionPointLineNumber APIs from AccessibilityControler. BUG=347859 R=dmazzoni Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193977

Patch Set 1 #

Patch Set 2 : Renamed some more tests for consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -472 lines) Patch
D LayoutTests/accessibility/input-text-caret-position.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/accessibility/input-text-caret-position-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/accessibility/input-text-selected-range.html View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/accessibility/input-text-selected-range-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/accessibility/input-type-password-selection.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/accessibility/input-type-password-selection-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
A LayoutTests/accessibility/input-type-password-value-and-selection.html View 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/input-type-password-value-and-selection-expected.txt View 1 chunk +103 lines, -0 lines 0 comments Download
A + LayoutTests/accessibility/input-type-text-caret-position.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/accessibility/input-type-text-caret-position-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/accessibility/input-type-text-selection.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/accessibility/input-type-text-selection-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/accessibility/insertion-point-line-number-on-password-crashes.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/accessibility/insertion-point-line-number-on-password-crashes-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/accessibility/textarea-selected-range.html View 1 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/accessibility/textarea-selected-range-expected.txt View 1 1 chunk +0 lines, -50 lines 0 comments Download
A + LayoutTests/accessibility/textarea-selection.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/accessibility/textarea-selection-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/accessibility/textbox-role-reports-selection.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/accessibility/textbox-role-reports-selection-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nektarios
5 years, 8 months ago (2015-04-17 18:37:12 UTC) #1
dmazzoni
lgtm
5 years, 8 months ago (2015-04-17 20:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050123003/20001
5 years, 8 months ago (2015-04-17 20:39:52 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 05:34:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193977

Powered by Google App Engine
This is Rietveld 408576698