Issue 1050113002: Revert of Remove promotion backup case and report OOM instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050113002: Revert of Remove promotion backup case and report OOM instead. (Closed)

Created:
5 years, 8 months ago by ulan

Modified:
5 years, 8 months ago

Reviewers:
Hannes Payer (out of office), Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Remove promotion backup case and report OOM instead. (patchset #2 id:20001 of https://codereview.chromium.org/977013003/) Reason for revert: Spike in OOM crashes: crbug.com/403113 Original issue's description: > Remove promotion backup case and report OOM instead. > > There are no test cases for this piece of code and it is really hard to test. If this rare case triggers, we are anyway in an OOM situation and would crash probably soon afterwards. > > BUG= > > Committed: https://crrev.com/e813afaf127ab80290153ab676dc07212bdc8946 > Cr-Commit-Position: refs/heads/master@{#27026} TBR=mstarzinger@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/bde8943968a4b09ee2e5150c09e62085970de820 Cr-Commit-Position: refs/heads/master@{#27568}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -21 lines)			Patch
	M	src/heap/heap.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/heap/mark-compact.cc	View		1 chunk	+19 lines, -20 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

Created Revert of Remove promotion backup case and report OOM instead.

5 years, 8 months ago (2015-04-01 15:37:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050113002/1

5 years, 8 months ago (2015-04-01 15:37:41 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 15:38:05 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bde8943968a4b09ee2e5150c09e62085970de820
Cr-Commit-Position: refs/heads/master@{#27568}