Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1050103002: Add missing isolates column to manage.py --remaining. (Closed)

Created:
5 years, 8 months ago by M-A Ruel
Modified:
5 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, jochen (gone - plz use gerrit), scottmg
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@3_convert_to_swarming
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing isolates column to manage.py --remaining. This permits to quickly determine the low hanging fruits, that is, the ones with an .isolate file already. Add check when converting a test that at least a .isolate exists for it. Print out all the builders converted with --convert. Add builders not supported on Swarming to the blacklist, to remove the need to edit the json files manually. R=phajdan.jr@chromium.org BUG=98637 Committed: https://crrev.com/f68b03b3115535d33255b856b1273d2ebceece33 Cr-Commit-Position: refs/heads/master@{#323482}

Patch Set 1 : . #

Patch Set 2 : Add blacklist to simplify our life #

Patch Set 3 : Add reference to bugs #

Patch Set 4 : Add more blacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M testing/buildbot/manage.py View 1 2 3 7 chunks +45 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
M-A Ruel
Sample outputs: $ ./manage.py --remaining Test Local Swarming Missing isolate accessibility_unittests 1 29 app_installer_unittests 2 ...
5 years, 8 months ago (2015-04-01 15:09:41 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-01 15:18:12 UTC) #3
M-A Ruel
On 2015/04/01 15:18:12, Paweł Hajdan Jr. wrote: > LGTM I added a blacklist of builders ...
5 years, 8 months ago (2015-04-01 15:31:54 UTC) #4
Paweł Hajdan Jr.
Still LGTM.
5 years, 8 months ago (2015-04-02 10:05:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050103002/80001
5 years, 8 months ago (2015-04-02 12:53:49 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 8 months ago (2015-04-02 14:38:58 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:25:15 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f68b03b3115535d33255b856b1273d2ebceece33
Cr-Commit-Position: refs/heads/master@{#323482}

Powered by Google App Engine
This is Rietveld 408576698