Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1050033003: Revert of Relax assert a little to fix flake on regress-3976 (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Relax assert a little to fix flake on regress-3976 (patchset #1 id:1 of https://codereview.chromium.org/1045763002/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Relax assert a little to fix flake on regress-3976 > > R=verwaest@chromium.org > NOTRY=true > BUG= > > Committed: https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 > Cr-Commit-Position: refs/heads/master@{#27515} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1912814f011845ff9fe1a4c4ad4857b9b7d6eda5 Cr-Commit-Position: refs/heads/master@{#27561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry Chromium.org
Created Revert of Relax assert a little to fix flake on regress-3976
5 years, 8 months ago (2015-04-01 09:20:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050033003/1
5 years, 8 months ago (2015-04-01 09:20:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 09:21:00 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 09:21:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1912814f011845ff9fe1a4c4ad4857b9b7d6eda5
Cr-Commit-Position: refs/heads/master@{#27561}

Powered by Google App Engine
This is Rietveld 408576698