Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: net/server/web_socket_encoder.cc

Issue 1050013002: [WebSocketExtensionParser] Have Consume.* methods return bool instead of using has_error() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed #7, Rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/websockets/websocket_basic_handshake_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/server/web_socket_encoder.cc
diff --git a/net/server/web_socket_encoder.cc b/net/server/web_socket_encoder.cc
index 8e1681c8a7233d3878fb0180fc16e5d88e4f3384..e35f75910a5e3e1a82523cf7a65f702808bf9f2a 100644
--- a/net/server/web_socket_encoder.cc
+++ b/net/server/web_socket_encoder.cc
@@ -251,8 +251,7 @@ void WebSocketEncoder::ParseExtensions(const std::string& header_value,
return;
WebSocketExtensionParser parser;
- parser.Parse(header_value);
- if (parser.has_error())
+ if (!parser.Parse(header_value))
return;
const std::vector<WebSocketExtension>& extensions = parser.extensions();
// TODO(tyoshino): Fail if this method is used for parsing a response and
« no previous file with comments | « no previous file | net/websockets/websocket_basic_handshake_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698