Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1049993003: Revert of [Android] Clean up old_interface in build/android/. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Clean up old_interface in build/android/. (patchset #3 id:40001 of https://codereview.chromium.org/1047703002/) Reason for revert: This make sharded perf tests fail everywhere, example: http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/2797 Original issue's description: > [Android] Clean up old_interface in build/android/. > > BUG=267773 > > Committed: https://crrev.com/32b3e358017c863318fa7cca3a3c41bb5d056c24 > Cr-Commit-Position: refs/heads/master@{#323135} TBR=perezju@chromium.org,klundberg@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/010471f8abd5087f7a1e494cb6609d29d034618c Cr-Commit-Position: refs/heads/master@{#323202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -70 lines) Patch
M build/android/pylib/base/base_test_runner.py View 3 chunks +5 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 2 chunks +0 lines, -17 lines 0 comments Download
M build/android/pylib/gtest/test_options.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 2 chunks +8 lines, -14 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/setup.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_case.py View 2 chunks +6 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_options.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/linker/setup.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/linker/test_runner.py View 2 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/screenshot.py View 2 chunks +3 lines, -7 lines 0 comments Download
M build/android/pylib/uiautomator/test_options.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +9 lines, -10 lines 0 comments Download
M build/android/test_runner.py View 4 chunks +6 lines, -0 lines 0 comments Download
M build/android/update_verification.py View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [Android] Clean up old_interface in build/android/.
5 years, 8 months ago (2015-04-01 08:35:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049993003/1
5 years, 8 months ago (2015-04-01 08:35:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 08:36:25 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 08:37:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/010471f8abd5087f7a1e494cb6609d29d034618c
Cr-Commit-Position: refs/heads/master@{#323202}

Powered by Google App Engine
This is Rietveld 408576698