Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/gn/value_unittest.cc

Issue 1049963002: Revert of tools/gn: fix escaping of backslashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/value.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/value_unittest.cc
diff --git a/tools/gn/value_unittest.cc b/tools/gn/value_unittest.cc
index f934e6601812ec48e3caf8b6c8592a83bd3de12f..9cbdaa2dda3699cede165227ec355163c4bcd85c 100644
--- a/tools/gn/value_unittest.cc
+++ b/tools/gn/value_unittest.cc
@@ -10,10 +10,6 @@
Value strval(nullptr, "hi\" $me\\you\\$\\\"");
EXPECT_EQ("hi\" $me\\you\\$\\\"", strval.ToString(false));
EXPECT_EQ("\"hi\\\" \\$me\\you\\\\\\$\\\\\\\"\"", strval.ToString(true));
-
- // crbug.com/470217
- Value strval2(nullptr, "\\foo\\\\bar\\");
- EXPECT_EQ("\"\\foo\\\\\\bar\\\\\"", strval2.ToString(true));
// Void type.
EXPECT_EQ("<void>", Value().ToString(false));
@@ -39,3 +35,4 @@
scope->SetValue("b", Value(nullptr, "hello, world"), nullptr);
EXPECT_EQ("{\n a = 42\n b = \"hello, world\"\n}", scopeval.ToString(false));
}
+
« no previous file with comments | « tools/gn/value.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698