Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: url/gurl.h

Issue 1049953003: Rename GURL::SchemeUsesTLS to SchemeIsCryptographic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/gurl.h
diff --git a/url/gurl.h b/url/gurl.h
index 5e804a10580365a8abedf7ac22a97a669f7bf589..b9136b81f6a8b962a79d3e0435addc614a1e6bb0 100644
--- a/url/gurl.h
+++ b/url/gurl.h
@@ -225,12 +225,13 @@ class URL_EXPORT GURL {
// Returns true if the scheme indicates a secure connection.
//
- // NOTE: This function is deprecated. You probably want |SchemeUsesTLS| (if
- // you just want to know if a scheme uses TLS for network transport) or
- // Chromium's |IsOriginSecure| for a higher-level test about an origin's
- // security. See those functions' documentation for more detail.
+ // NOTE: This function is deprecated. You probably want
+ // |SchemeIsCryptographic| (if you just want to know if a scheme uses TLS for
+ // network transport) or Chromium's |IsOriginSecure| for a higher-level test
+ // about an origin's security. See those functions' documentation for more
+ // detail.
//
- // TODO(palmer): Audit callers and change them to |SchemeUsesTLS| or
+ // TODO(palmer): Audit callers and change them to |SchemeIsCryptographic| or
// |IsOriginSecure|, as appropriate. Then remove |SchemeIsSecure|.
// crbug.com/362214
bool SchemeIsSecure() const {
@@ -239,14 +240,14 @@ class URL_EXPORT GURL {
inner_url()->SchemeIsSecure());
}
- // Returns true if the scheme indicates a network connection that uses TLS for
- // security.
+ // Returns true if the scheme indicates a network connection that uses TLS or
+ // some other cryptographic protocol (e.g. QUIC) for security.
//
// This function is a not a complete test of whether or not an origin's code
// is minimally trustworthy. For that, see Chromium's |IsOriginSecure| for a
// higher-level and more complete semantics. See that function's documentation
// for more detail.
- bool SchemeUsesTLS() const {
+ bool SchemeIsCryptographic() const {
return SchemeIs(url::kHttpsScheme) || SchemeIs(url::kWssScheme);
}
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698