Export shouldTreatURLSchemeAsSecure.

Export shouldTreatURLSchemeAsSecure.

BUG=362214
TBR=brettw,abarth

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193143

[palmer, 2015-04-01 01:36:52]

palmer@chromium.org changed reviewers:
+ abarth@chromium.org, brettw@chromium.org, tsepez@chromium.org

[palmer, 2015-04-01 01:36:53]

This CL is a precursor to resolving a TODO in
https://codereview.chromium.org/1049533002/:

// TODO(palmer): In a higher layer, such as content/, add a new function that
// wraps this function and takes into account the schemes registered with
// |WebSecurityPolicy::registerURLSchemeAsSecure| in Blink. crbug.com/362214.

[Tom Sepez, 2015-04-01 17:11:49]

lgtm

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
File Source/platform/weborigin/SchemeRegistry.h (right):

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
Source/platform/weborigin/SchemeRegistry.h:51: // For example, https and wss are
secure schemes because they cannot be
nit: It's weird to start a comment with "For example".  I'd have left the
comment alone, apart from adding "Subresources transported by" to the beginning.

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
Source/platform/weborigin/SchemeRegistry.h:53: // network attackers..
Subresources transported by secure schemes do not
nit: ..

https://codereview.chromium.org/1049923002/diff/1/public/web/WebSecurityPolicy.h
File public/web/WebSecurityPolicy.h (right):

https://codereview.chromium.org/1049923002/diff/1/public/web/WebSecurityPolic...
public/web/WebSecurityPolicy.h:64: // For example, https and wss are secure
schemes because they cannot be
nit: same here.

[palmer, 2015-04-03 19:21:44]

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
File Source/platform/weborigin/SchemeRegistry.h (right):

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
Source/platform/weborigin/SchemeRegistry.h:51: // For example, https and wss are
secure schemes because they cannot be
On 2015/04/01 17:11:49, Tom Sepez wrote:
> nit: It's weird to start a comment with "For example".  I'd have left the
> comment alone, apart from adding "Subresources transported by" to the
beginning.

Done.

https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/S...
Source/platform/weborigin/SchemeRegistry.h:53: // network attackers..
Subresources transported by secure schemes do not
On 2015/04/01 17:11:49, Tom Sepez wrote:
> nit: ..

Done.

https://codereview.chromium.org/1049923002/diff/1/public/web/WebSecurityPolicy.h
File public/web/WebSecurityPolicy.h (right):

https://codereview.chromium.org/1049923002/diff/1/public/web/WebSecurityPolic...
public/web/WebSecurityPolicy.h:64: // For example, https and wss are secure
schemes because they cannot be
On 2015/04/01 17:11:49, Tom Sepez wrote:
> nit: same here.

Done.

[palmer, 2015-04-03 20:41:06]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[palmer, 2015-04-03 20:41:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1049923002/#ps20001
(title: "Fix comment nits.")

[commit-bot: I haz the power, 2015-04-03 20:41:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049923002/20001

[commit-bot: I haz the power, 2015-04-03 21:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 21:54:54]

This issue passed the CQ dry run.

[palmer, 2015-04-03 22:07:06]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2015-04-03 22:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049923002/20001

[commit-bot: I haz the power, 2015-04-03 22:08:08]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193143

[Mike West, 2015-04-04 05:23:35]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-04-04 05:23:36]

public/web LGTM.

[Mike West, 2015-04-04 05:23:51]

On 2015/04/04 at 05:23:36, Mike West (OOO until 7th) wrote:
> public/web LGTM.

(and Source/platform, and everything else).