Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1049923002: Export shouldTreatURLSchemeAsSecure. (Closed)

Created:
5 years, 8 months ago by palmer
Modified:
5 years, 8 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Export shouldTreatURLSchemeAsSecure. BUG=362214 TBR=brettw,abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193143

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix comment nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M Source/platform/weborigin/SchemeRegistry.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebSecurityPolicy.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSecurityPolicy.h View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
palmer
This CL is a precursor to resolving a TODO in https://codereview.chromium.org/1049533002/: // TODO(palmer): In a ...
5 years, 8 months ago (2015-04-01 01:36:53 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/SchemeRegistry.h File Source/platform/weborigin/SchemeRegistry.h (right): https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/SchemeRegistry.h#newcode51 Source/platform/weborigin/SchemeRegistry.h:51: // For example, https and wss are secure ...
5 years, 8 months ago (2015-04-01 17:11:49 UTC) #3
palmer
https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/SchemeRegistry.h File Source/platform/weborigin/SchemeRegistry.h (right): https://codereview.chromium.org/1049923002/diff/1/Source/platform/weborigin/SchemeRegistry.h#newcode51 Source/platform/weborigin/SchemeRegistry.h:51: // For example, https and wss are secure schemes ...
5 years, 8 months ago (2015-04-03 19:21:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049923002/20001
5 years, 8 months ago (2015-04-03 20:41:31 UTC) #7
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-03 21:54:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049923002/20001
5 years, 8 months ago (2015-04-03 22:07:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193143
5 years, 8 months ago (2015-04-03 22:08:08 UTC) #12
Mike West
public/web LGTM.
5 years, 8 months ago (2015-04-04 05:23:36 UTC) #14
Mike West
5 years, 8 months ago (2015-04-04 05:23:51 UTC) #15
Message was sent while issue was closed.
On 2015/04/04 at 05:23:36, Mike West (OOO until 7th) wrote:
> public/web LGTM.

(and Source/platform, and everything else).

Powered by Google App Engine
This is Rietveld 408576698