1. A small fix of Windows VM size.

1. A small fix of Windows VM size.
2. Re-format TCMalloc dump output (about:tcmalloc)

BUG=130840
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140447

[jar (doing other things), 2012-06-04 04:31:27]

I like the recording of the meta data usage... but I think you should try to be
as minimalist as possible when diverging from the standard distribution.  ...you
need a real good reason for each change.

Adding the basic print of the new field (properly tallied field?) is fine.

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/pagemap.h (right):

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/pagemap.h:261: // TODO(jar): We need a commit
that automatically tallies metadata_bytes.
Should we remove this TODO now?

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/tcmalloc.cc (right):

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/tcmalloc.cc:395: "WASTE: = %7.1f MiB bytes
committed\n"
I think I like your formatting better... but does it add enough value to branch
away from the standard distribution?

(I'm looking at the above 4 lines only, vs the 3 lines of the existing file).

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/tcmalloc.cc:397: bytes_in_use_by_app / MiB,
This probably shouldn't be moved... as it just makes merging harder.

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/tcmalloc.cc:414: "MALLOC: = %12" PRIu64 "
(%7.1f MiB) Bytes committed\n"
again... I like your format better... but I'd rather make merges easier and not
move this line.

[kaiwang, 2012-06-04 18:30:52]

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/pagemap.h (right):

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/pagemap.h:261: // TODO(jar): We need a commit
that automatically tallies metadata_bytes.
Done.
It's not exactly what I did. But I also feel this TODO is hard to address (maybe
not necessary).

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/tcmalloc.cc (right):

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/tcmalloc.cc:395: "WASTE: = %7.1f MiB bytes
committed\n"
This WASTE part(line 391-401) is chromium only, does not exist in gperftools. :)

http://codereview.chromium.org/10499004/diff/6001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/tcmalloc.cc:414: "MALLOC: = %12" PRIu64 "
(%7.1f MiB) Bytes committed\n"
This single line is actually chromium code (again :). Last merging had some
mistake and put it in wrong place, so the about:tcmalloc become nonsense:
https://code.google.com/p/chromium/issues/detail?id=130840

[jar (doing other things), 2012-06-04 23:19:35]

lgtm

[commit-bot: I haz the power, 2012-06-04 23:31:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10499004/11001

[commit-bot: I haz the power, 2012-06-05 00:33:43]

Change committed as 140447