Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1049873007: Refactored HostDaemonFacade so that replies to requests are handled in (Closed)

Created:
5 years, 8 months ago by John Williams
Modified:
5 years, 8 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored HostDaemonFacade so that replies to requests are handled in the same method that sends the request. BUG=471928 Committed: https://crrev.com/64f215bf461b16cc9708b5ae3a10ddef62f087df Cr-Commit-Position: refs/heads/master@{#326947}

Patch Set 1 #

Total comments: 2

Patch Set 2 : for submit #

Patch Set 3 : sync to head #

Patch Set 4 : fixed broken merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -122 lines) Patch
M remoting/webapp/crd/js/host_daemon_facade.js View 1 2 3 20 chunks +82 lines, -122 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
John Williams
The refactoring you requested :-)
5 years, 8 months ago (2015-04-23 20:13:17 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/1049873007/diff/1/remoting/webapp/crd/js/host_daemon_facade.js File remoting/webapp/crd/js/host_daemon_facade.js (right): https://codereview.chromium.org/1049873007/diff/1/remoting/webapp/crd/js/host_daemon_facade.js#newcode99 remoting/webapp/crd/js/host_daemon_facade.js:99: return null; nit s/return null/return for consistency within ...
5 years, 8 months ago (2015-04-24 21:59:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049873007/20001
5 years, 8 months ago (2015-04-24 22:10:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/46489) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-24 22:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049873007/60001
5 years, 8 months ago (2015-04-25 00:20:11 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-25 01:24:30 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 01:25:27 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/64f215bf461b16cc9708b5ae3a10ddef62f087df
Cr-Commit-Position: refs/heads/master@{#326947}

Powered by Google App Engine
This is Rietveld 408576698