chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system_logs/dbus_log_source.cc ('k') | chrome/browser/chromeos/system_logs/device_event_log_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

diff --git a/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc b/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

index d1780f924c33f7360b7c118c5dc4e761262b4890..263d03cb4383400d88b410081bee0b9d379dd798 100644

--- a/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

+++ b/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc

@@ -39,7 +39,7 @@ DebugDaemonLogSource::DebugDaemonLogSource(bool scrub)

DebugDaemonLogSource::~DebugDaemonLogSource() {}

void DebugDaemonLogSource::Fetch(const SysLogsSourceCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

DCHECK(!callback.is_null());

DCHECK(callback_.is_null());

@@ -77,7 +77,7 @@ void DebugDaemonLogSource::Fetch(const SysLogsSourceCallback& callback) {

void DebugDaemonLogSource::OnGetRoutes(bool succeeded,

const std::vector<std::string>& routes) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (succeeded)

(*response_)[kRoutesKeyName] = JoinString(routes, '\n');

@@ -88,7 +88,7 @@ void DebugDaemonLogSource::OnGetRoutes(bool succeeded,

void DebugDaemonLogSource::OnGetNetworkStatus(bool succeeded,

const std::string& status) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (succeeded)

(*response_)[kNetworkStatusKeyName] = status;