Support output of heading levels.

Support output of heading levels.

- adds rules for headings, both entering and speaking.
- adds a '+' delimiter which allows for subsittutions inside of message tokens.

TEST=OutputE2ETest.*

Committed: https://crrev.com/1185dbb2943f95827013b531ef61c910131648a9
Cr-Commit-Position: refs/heads/master@{#325566}

[David Tseng, 2015-03-31 23:49:37]

dtseng@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2015-04-02 09:43:54]

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:157:
enter: '@aria_role_heading -$hierarchicalLevel',
Need to add this prefix to the documentation in the
constructor.
Not sure I like the minus prefix, however, it looks like some kind
of exclusion.  Would a plus sign (as a connector rather than prefix or suffix)
be an option?
another alternative would be to turn this around and make comma
split the utterances and make the default be to not split. For braille,
comma could then just insert whiespace and the default would be to ignore
whitespace in the string.
Or we could have a more verbose named token (such as '$nosplit') to not make
this domain specific language too obscure.

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:501: if
(prefix == '-') {
There's an implicit ordering of prefixes here.  Should we try to write some
grammar
for this language before it grows out of hand?

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
(right):

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs:65:
});
Check the braille output?

[David Tseng, 2015-04-02 23:50:49]

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1049853002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:501: if
(prefix == '-') {
On 2015/04/02 09:43:54, Peter Lundblad wrote:
> There's an implicit ordering of prefixes here.  Should we try to write some
> grammar
> for this language before it grows out of hand?

You're probably right. I can take a look at some js based parser generators so
we can replace most of this file's parsing logic with just an input grammar.

[David Tseng, 2015-04-09 21:14:11]

PTAL.

Looked at parser/lexer solutions...seems heavy weight for what we're doing here.

I changed the syntax a little to allow for substitutions in the message id. Let
me know what you think. This also just reuses the existing strings that
exhaustively list all the heading levels (including for braille).

[David Tseng, 2015-04-15 20:46:56]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2015-04-15 20:46:56]

+ dmazzoni. Mind taking a look at this one too? Thanks.

[dmazzoni, 2015-04-15 21:06:06]

lgtm

https://codereview.chromium.org/1049853002/diff/20002/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
(right):

https://codereview.chromium.org/1049853002/diff/20002/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs:138:
assertEqualsJSON({string_: 'Heading 1a', 'spans_': [
I'd be happier if toSpannable didn't run things together like this. How about if
it output "Heading 1 | a" or something like that"?

For a future change, how about if there was a pretty-print option for an Output
that conveys all of the text and attributes as a string. That'd make tests and
debugging a lot cleaner.

[David Tseng, 2015-04-16 23:45:58]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2015-04-16 23:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1049853002/#ps70001
(title: " ")

[commit-bot: I haz the power, 2015-04-16 23:47:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049853002/70001

[commit-bot: I haz the power, 2015-04-17 00:28:36]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2015-04-17 00:29:31]

Patchset 5 (id:??) landed as
https://crrev.com/1185dbb2943f95827013b531ef61c910131648a9
Cr-Commit-Position: refs/heads/master@{#325566}