Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1049833004: Add flag for MTP write support. (Closed)

Created:
5 years, 8 months ago by yawano
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag for MTP write support. BUG=413541 TEST=manually tested. Committed: https://crrev.com/e6a41b132391ffdfdacb8d36990ad4db51ecf3a1 Cr-Commit-Position: refs/heads/master@{#323671}

Patch Set 1 #

Patch Set 2 : Add histogram value. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
yawano
Put MTP write support behind flag. PTAL. Thank you!
5 years, 8 months ago (2015-04-01 04:29:48 UTC) #2
Lei Zhang
lgtm, but you need a chromeos/OWNERS too.
5 years, 8 months ago (2015-04-01 18:12:25 UTC) #3
yawano
Thank you! For chromeos_swtiches, everyone has the owner. Do you mean that it's better to ...
5 years, 8 months ago (2015-04-02 01:57:35 UTC) #4
Lei Zhang
On 2015/04/02 01:57:35, yawano wrote: > Thank you! For chromeos_swtiches, everyone has the owner. Do ...
5 years, 8 months ago (2015-04-02 02:03:17 UTC) #5
yawano
On 2015/04/02 02:03:17, Lei Zhang wrote: > On 2015/04/02 01:57:35, yawano wrote: > > Thank ...
5 years, 8 months ago (2015-04-02 02:04:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049833004/1
5 years, 8 months ago (2015-04-02 02:04:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/3880)
5 years, 8 months ago (2015-04-02 03:47:51 UTC) #10
Lei Zhang
Oh, right. Forgot to tell you to add the new flag to the histograms.
5 years, 8 months ago (2015-04-02 04:37:22 UTC) #11
yawano
@isherman: PTAL histograms.xml. Thank you!
5 years, 8 months ago (2015-04-02 04:55:27 UTC) #13
Ilya Sherman
lgtm
5 years, 8 months ago (2015-04-02 17:16:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049833004/20001
5 years, 8 months ago (2015-04-02 17:17:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/42615)
5 years, 8 months ago (2015-04-02 17:51:49 UTC) #19
yawano
On 2015/04/02 17:16:18, Ilya Sherman wrote: > lgtm Thank you!
5 years, 8 months ago (2015-04-03 00:35:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049833004/40001
5 years, 8 months ago (2015-04-03 00:52:48 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-03 07:52:09 UTC) #24
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:34:33 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e6a41b132391ffdfdacb8d36990ad4db51ecf3a1
Cr-Commit-Position: refs/heads/master@{#323671}

Powered by Google App Engine
This is Rietveld 408576698