Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1049833003: Fix dependency issue with install-build-deps.sh on Trusty (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dependency issue with install-build-deps.sh on Trusty Trusty seems to have dificulty installing gcc-arm-linux-gnueabihf and gcc-4.8-multilib without these extra packages being listed on the install line also. BUG=435056 Committed: https://crrev.com/b5d4ded25739d583663fd17569de96394f84c267 Cr-Commit-Position: refs/heads/master@{#323281}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/install-build-deps.sh View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Sam Clegg
5 years, 8 months ago (2015-04-01 01:10:59 UTC) #2
friedman1
lgtm https://codereview.chromium.org/1049833003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1049833003/diff/1/build/install-build-deps.sh#newcode158 build/install-build-deps.sh:158: # Work around for dependency issue Ubuntu/Trusty: http://crbug/435056 ...
5 years, 8 months ago (2015-04-01 01:15:02 UTC) #4
Sam Clegg
https://codereview.chromium.org/1049833003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1049833003/diff/1/build/install-build-deps.sh#newcode158 build/install-build-deps.sh:158: # Work around for dependency issue Ubuntu/Trusty: http://crbug/435056 On ...
5 years, 8 months ago (2015-04-01 16:51:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049833003/20001
5 years, 8 months ago (2015-04-01 16:51:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53334)
5 years, 8 months ago (2015-04-01 17:03:12 UTC) #10
Sam Clegg
+dpranke for build/OWNERS
5 years, 8 months ago (2015-04-01 17:12:57 UTC) #12
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-01 17:16:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049833003/20001
5 years, 8 months ago (2015-04-01 17:44:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 17:49:12 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 17:50:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5d4ded25739d583663fd17569de96394f84c267
Cr-Commit-Position: refs/heads/master@{#323281}

Powered by Google App Engine
This is Rietveld 408576698