Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1049763002: Guard hid_service_win.h include with OS_WIN. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard hid_service_win.h include with OS_WIN. R=reillyg@chromium.org BUG=None Committed: https://crrev.com/540e283dab10a46f48ba8e69d60751ac3325a7e8 Cr-Commit-Position: refs/heads/master@{#323066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/hid/hid_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
Was discovered while building |chromium_builder_tests| with chromecast==1 (sets OS_LINUX but not USE_UDEV).
5 years, 8 months ago (2015-03-31 16:37:18 UTC) #1
Reilly Grant (use Gerrit)
lgtm
5 years, 8 months ago (2015-03-31 16:46:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049763002/1
5 years, 8 months ago (2015-03-31 16:47:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 17:43:14 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 17:44:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/540e283dab10a46f48ba8e69d60751ac3325a7e8
Cr-Commit-Position: refs/heads/master@{#323066}

Powered by Google App Engine
This is Rietveld 408576698