SkPDF: Factor SkPDFCatalog into SkPDFObjNumMap and SkPDFSubstituteMap

SkPDF: Factor SkPDFCatalog into SkPDFObjNumMap and SkPDFSubstituteMap

Motivation: Keep separate features separate.  Also, future
linearization work will need to have several objNumMap
objects share a substituteMap.  Also "catalog" has a
specific meaning in PDF.  This catalog did not map to that
catalog.

-   Modify SkPDFObject::emitObject and SkPDFObject::addResources
    interface to requiore SkPDFObjNumMap and SkPDFSubstituteMap.
-   SkPDFObjNumMap const in SkPDFObject::emitObject.
-   Remove SkPDFCatalog.cpp/.h
-   Modify SkDocument_PDF.cpp to use new functions
-   Fold in SkPDFStream::populate
-   Fold in SkPDFBitmap::emitDict
-   Move SkPDFObjNumMap and SkPDFSubstituteMap to SkPDFTypes.h
-   Note (via assert) that SkPDFArray & SkPDFDict don't need to
    check substitutes.
-   Remove extra space from SkPDFDict serialization.
-   SkPDFBitmap SkPDFType0Font SkPDFGraphicState SkPDFStream
    updated to new interface.
-   PDFPrimitivesTest updated for new interface.

BUG=skia:3585
Committed: https://skia.googlesource.com/skia/+/37c46cad21632cfc1411b08d73af37a1fffe2944

[hal.canary, 2015-03-31 15:15:53]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-03-31 15:16:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049753002/1

[commit-bot: I haz the power, 2015-03-31 15:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 15:16:08]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hal.canary, 2015-03-31 15:17:53]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-03-31 15:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049753002/1

[hal.canary, 2015-03-31 15:18:18]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-03-31 15:18:18]

ptal

[hal.canary, 2015-03-31 15:32:50]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-03-31 15:33:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049753002/20001

[commit-bot: I haz the power, 2015-03-31 15:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 15:33:10]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hal.canary, 2015-03-31 18:56:17]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-03-31 18:56:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049753002/40001

[commit-bot: I haz the power, 2015-03-31 19:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 19:05:01]

This issue passed the CQ dry run.

[hal.canary, 2015-03-31 19:08:36]

changes made.

[mtklein, 2015-03-31 19:29:20]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-03-31 19:29:21]

lgtm

https://codereview.chromium.org/1049753002/diff/40001/src/pdf/SkPDFStream.cpp
File src/pdf/SkPDFStream.cpp (right):

https://codereview.chromium.org/1049753002/diff/40001/src/pdf/SkPDFStream.cpp...
src/pdf/SkPDFStream.cpp:40: insertName("Filter", "FlateDecode");
It'd be nice to tack on this-> to these insertFoo calls while we're looking.

[commit-bot: I haz the power, 2015-03-31 19:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049753002/40001

[commit-bot: I haz the power, 2015-03-31 19:30:25]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/37c46cad21632cfc1411b08d73af37a1fffe2944

[hal.canary, 2015-03-31 19:32:48]

Someday I'll touch every line of code in the module.

https://codereview.chromium.org/1049753002/diff/40001/src/pdf/SkPDFStream.cpp
File src/pdf/SkPDFStream.cpp (right):

https://codereview.chromium.org/1049753002/diff/40001/src/pdf/SkPDFStream.cpp...
src/pdf/SkPDFStream.cpp:40: insertName("Filter", "FlateDecode");
On 2015/03/31 19:29:21, mtklein wrote:
> It'd be nice to tack on this-> to these insertFoo calls while we're looking.

will do.