Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1049703004: Upstream web js bundle. (Closed)

Created:
5 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 8 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream web js bundle. BUG=464810 Committed: https://crrev.com/4cbc86b2ec585bebf2a1771cefbf7f5fd17cb7cc Cr-Commit-Position: refs/heads/master@{#323111}

Patch Set 1 #

Patch Set 2 : Added compile_javascript variable to js_compile.gypi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -25 lines) Patch
M ios/web/ios_web.gyp View 2 chunks +69 lines, -10 lines 0 comments Download
M ios/web/js_compile.gypi View 1 1 chunk +47 lines, -15 lines 0 comments Download
A ios/web/js_compile_bundle.gypi View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Eugene But (OOO till 7-30)
5 years, 8 months ago (2015-03-31 18:38:34 UTC) #2
stuartmorgan
lgtm
5 years, 8 months ago (2015-03-31 20:03:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049703004/20001
5 years, 8 months ago (2015-03-31 20:12:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 21:22:37 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 21:23:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cbc86b2ec585bebf2a1771cefbf7f5fd17cb7cc
Cr-Commit-Position: refs/heads/master@{#323111}

Powered by Google App Engine
This is Rietveld 408576698