Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/assembler.cc

Issue 1049703002: Make compilers agree on source position of thrown errors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix another regression. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index 19662c44972da9aab22ccac15b45fdc3efedbc3f..e5924cdf75df81c057cfb109ba695cc706ee7469 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1615,19 +1615,20 @@ bool PositionsRecorder::WriteRecordedPositions() {
EnsureSpace ensure_space(assembler_);
assembler_->RecordRelocInfo(RelocInfo::STATEMENT_POSITION,
state_.current_statement_position);
- state_.written_statement_position = state_.current_statement_position;
written = true;
}
+ state_.written_statement_position = state_.current_statement_position;
// Write the position if it is different from what was written last time and
- // also different from the written statement position.
+ // also different from the statement position that was just written.
if (state_.current_position != state_.written_position &&
- state_.current_position != state_.written_statement_position) {
+ (state_.current_position != state_.written_statement_position ||
+ !written)) {
EnsureSpace ensure_space(assembler_);
assembler_->RecordRelocInfo(RelocInfo::POSITION, state_.current_position);
- state_.written_position = state_.current_position;
written = true;
}
+ state_.written_position = state_.current_position;
// Return whether something was written.
return written;
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698