Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: test/mjsunit/harmony/debug-step-into-constructor.js

Issue 1049703002: Make compilers agree on source position of thrown errors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Adapt one more test expectation. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/harmony/debug-step-into-constructor.js
diff --git a/test/mjsunit/harmony/debug-step-into-constructor.js b/test/mjsunit/harmony/debug-step-into-constructor.js
index dbef60f8465af4d629ac8ffb00868a2627fa2395..737748cd299afb5df5f3eeace4fb5a886f5815fd 100644
--- a/test/mjsunit/harmony/debug-step-into-constructor.js
+++ b/test/mjsunit/harmony/debug-step-into-constructor.js
@@ -24,10 +24,10 @@ Debug.setListener(listener);
class Base {
- constructor() {
- var x = 1; // 1.
- var y = 2; // 2.
- done = true; // 3.
+ constructor() { // 1.
Michael Starzinger 2015/04/10 11:49:12 Arv: Can you please advise on this change. Does th
Michael Starzinger 2015/04/10 13:56:40 OK, I managed to find this regression and fixed it
+ var x = 1; // 2.
+ var y = 2; // 3.
+ done = true; // 4.
}
}
@@ -40,7 +40,7 @@ class Derived extends Base {}
var bp = Debug.setBreakPoint(Base, 0);
new Base();
- assertEquals(4, stepCount);
+ assertEquals(5, stepCount);
Debug.clearBreakPoint(bp);
})();
@@ -52,7 +52,7 @@ class Derived extends Base {}
var bp = Debug.setBreakPoint(Base, 0);
new Derived();
- assertEquals(4, stepCount);
+ assertEquals(5, stepCount);
Debug.clearBreakPoint(bp);
})();
@@ -68,7 +68,7 @@ class Derived extends Base {}
var bp = Debug.setBreakPoint(f, 0);
f();
- assertEquals(4, stepCount);
+ assertEquals(5, stepCount);
Debug.clearBreakPoint(bp);
})();
@@ -86,7 +86,7 @@ class Derived extends Base {}
var bp = Debug.setBreakPoint(f, 0);
f();
- assertEquals(4, stepCount);
+ assertEquals(5, stepCount);
Debug.clearBreakPoint(bp);
})();
@@ -104,7 +104,7 @@ class Derived extends Base {}
var bp = Debug.setBreakPoint(f, 0);
f();
- assertEquals(4, stepCount);
+ assertEquals(5, stepCount);
Debug.clearBreakPoint(bp);
})();

Powered by Google App Engine
This is Rietveld 408576698