src/full-codegen.cc - Issue 1049703002: Make compilers agree on source position of thrown errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 1049703002: Make compilers agree on source position of thrown errors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adapt one more test expectation. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index d70ab80d2cc7999ef5cb99d73078404dcfca28a7..6acfb97de3a5321b91d9d22a3c0d2de4f2f9535b 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1639,6 +1639,7 @@ void FullCodeGenerator::VisitNativeFunctionLiteral(

void FullCodeGenerator::VisitThrow(Throw* expr) {

Comment cmnt(masm_, "[ Throw");

VisitForStackValue(expr->exception());

+ SetSourcePosition(expr->position());

__ CallRuntime(Runtime::kThrow, 1);

// Never returns here.

}