chrome/common/origin_util.h - Issue 1049533002: Add IsOriginSecure and GURL::SchemeUsesTLS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/origin_util.h

Issue 1049533002: Add IsOriginSecure and GURL::SchemeUsesTLS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update the commit message to reflect the changes. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_ORIGIN_UTIL_H_

	6 #define CHROME_COMMON_ORIGIN_UTIL_H_

	7

	8 class GURL;

	9

	10 // Returns true if the origin is secure.

	11 //

	12 // This function calls into \|content::IsOriginSecure\|, and then additionally

	13 // checks for certain Chromium-specific secure URL schemes.

	14 //

	15 // See https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.
	davidben 2015/04/08 20:31:00 Having both chrome:: and content:: versions of thi Having both chrome:: and content:: versions of this function seems like it'd cause problems. Code in content that defines polices will likely need to know about origins that chrome considers secure, no? How does Blink learn that these schemes are secure right now? Probably would make sense to route into that. Or maybe moving it into content/common if it only happens in one process. (I see a ContentClient::AddAdditionalSchemes.)
	16 bool IsOriginSecure(const GURL& url);

	17

	18 #endif // CHROME_COMMON_ORIGIN_UTIL_H_

OLD	NEW