Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 1049513003: Add error dispatch events to SVGStyleElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index b73a0e6d79993ba563a7a2563b580e517f21065c..baaa4da8c3e9fb4216acb1ac89f99726996ae0dc 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -783,13 +783,14 @@ bool SVGElement::removeEventListener(const AtomicString& eventType, PassRefPtr<E
return true;
}
-static bool hasLoadListener(Element* element)
+static bool hasEventListener(Element* element, const AtomicString& eventType)
{
- if (element->hasEventListeners(EventTypeNames::load))
+ ASSERT(eventType == EventTypeNames::load || eventType == EventTypeNames::error);
+ if (element->hasEventListeners(eventType))
return true;
for (element = element->parentOrShadowHostElement(); element; element = element->parentOrShadowHostElement()) {
- const EventListenerVector& entry = element->getEventListeners(EventTypeNames::load);
+ const EventListenerVector& entry = element->getEventListeners(eventType);
for (size_t i = 0; i < entry.size(); ++i) {
if (entry[i].useCapture)
return true;
@@ -803,7 +804,7 @@ bool SVGElement::sendSVGLoadEventIfPossible()
{
if (!haveLoadedRequiredResources())
return false;
- if ((isStructurallyExternal() || isSVGSVGElement(*this)) && hasLoadListener(this))
+ if ((isStructurallyExternal() || isSVGSVGElement(*this)) && hasEventListener(this, EventTypeNames::load))
dispatchEvent(Event::create(EventTypeNames::load));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698