Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: Source/core/html/HTMLStyleElement.cpp

Issue 1049513003: Add error dispatch events to SVGStyleElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added more tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLStyleElement.cpp
diff --git a/Source/core/html/HTMLStyleElement.cpp b/Source/core/html/HTMLStyleElement.cpp
index 2d6b0366b2c7dfb82f4dc3a313d291c0a170a04d..b169020abd187730862e1df95edb3b59fa79acb7 100644
--- a/Source/core/html/HTMLStyleElement.cpp
+++ b/Source/core/html/HTMLStyleElement.cpp
@@ -143,7 +143,7 @@ void HTMLStyleElement::dispatchPendingEvent(StyleEventSender* eventSender)
void HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources(LoadedSheetErrorStatus errorStatus)
{
- if (m_firedLoad)
+ if (m_firedLoad && errorStatus == NoErrorLoadingSubresource)
pdr. 2015/03/31 03:01:43 This looks like it can lead to firing more than on
jww 2015/03/31 21:31:42 I'm fairly sure this is correct, but double check
fs 2015/04/01 08:47:50 Maybe something like: bool sheetWasLoaded = error
return;
m_loadedSheet = (errorStatus == NoErrorLoadingSubresource);
styleLoadEventSender().dispatchEventSoon(this);

Powered by Google App Engine
This is Rietveld 408576698