Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/core/svg/SVGElement.h

Issue 1049513003: Add error dispatch events to SVGStyleElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added more tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 virtual void svgAttributeChanged(const QualifiedName&); 96 virtual void svgAttributeChanged(const QualifiedName&);
97 97
98 PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase> propertyFromAttribute(const QualifiedName& attributeName); 98 PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase> propertyFromAttribute(const QualifiedName& attributeName);
99 static AnimatedPropertyType animatedPropertyTypeForCSSAttribute(const Qualif iedName& attributeName); 99 static AnimatedPropertyType animatedPropertyTypeForCSSAttribute(const Qualif iedName& attributeName);
100 100
101 void sendSVGLoadEventToSelfAndAncestorChainIfPossible(); 101 void sendSVGLoadEventToSelfAndAncestorChainIfPossible();
102 bool sendSVGLoadEventIfPossible(); 102 bool sendSVGLoadEventIfPossible();
103 void sendSVGLoadEventIfPossibleAsynchronously(); 103 void sendSVGLoadEventIfPossibleAsynchronously();
104 void svgLoadEventTimerFired(Timer<SVGElement>*); 104 void svgLoadEventTimerFired(Timer<SVGElement>*);
105 virtual Timer<SVGElement>* svgLoadEventTimer(); 105 virtual Timer<SVGElement>* svgLoadEventTimer();
106 bool sendSVGErrorEventIfPossible();
pdr. 2015/03/31 03:01:43 Should this be void instead of bool?
jww 2015/03/31 21:31:42 Yes, although this goes away given fs@'s comments
107 void sendSVGErrorEventIfPossibleAsynchronously();
108 void svgErrorEventTimerFired(Timer<SVGElement>*);
109 virtual Timer<SVGElement>* svgErrorEventTimer();
pdr. 2015/03/31 03:01:43 Can you put the above 4 functions (err, it will be
fs 2015/03/31 09:03:38 Agreed - with the below twist.
jww 2015/03/31 21:31:42 Done.
106 110
107 virtual AffineTransform* animateMotionTransform() { return 0; } 111 virtual AffineTransform* animateMotionTransform() { return 0; }
108 112
109 void invalidateSVGAttributes() { ensureUniqueElementData().m_animatedSVGAttr ibutesAreDirty = true; } 113 void invalidateSVGAttributes() { ensureUniqueElementData().m_animatedSVGAttr ibutesAreDirty = true; }
110 void invalidateSVGPresentationAttributeStyle() { ensureUniqueElementData().m _presentationAttributeStyleIsDirty = true; } 114 void invalidateSVGPresentationAttributeStyle() { ensureUniqueElementData().m _presentationAttributeStyleIsDirty = true; }
111 void addSVGLengthPropertyToPresentationAttributeStyle(MutableStylePropertySe t*, CSSPropertyID, SVGLength&); 115 void addSVGLengthPropertyToPresentationAttributeStyle(MutableStylePropertySe t*, CSSPropertyID, SVGLength&);
112 116
113 const WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement>>& instancesForEle ment() const; 117 const WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement>>& instancesForEle ment() const;
114 void mapInstanceToElement(SVGElement*); 118 void mapInstanceToElement(SVGElement*);
115 void removeInstanceMapping(SVGElement*); 119 void removeInstanceMapping(SVGElement*);
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 template<typename T> inline bool is##thisType(const PassRefPtrWillBeRawPtr<T >& node) { return is##thisType(node.get()); } \ 286 template<typename T> inline bool is##thisType(const PassRefPtrWillBeRawPtr<T >& node) { return is##thisType(node.get()); } \
283 template<typename T> inline bool is##thisType(const RefPtrWillBeMember<T>& n ode) { return is##thisType(node.get()); } \ 287 template<typename T> inline bool is##thisType(const RefPtrWillBeMember<T>& n ode) { return is##thisType(node.get()); } \
284 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \ 288 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \
285 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 289 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
286 290
287 } // namespace blink 291 } // namespace blink
288 292
289 #include "core/SVGElementTypeHelpers.h" 293 #include "core/SVGElementTypeHelpers.h"
290 294
291 #endif // SVGElement_h 295 #endif // SVGElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698