Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 1049513002: Use the ICU syntax message for plural formatting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios whitelist update Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index ee181e0b1b6fa4e597236000433050a56eafc8b2..1eed54c75e0a8b62f237e405845c78c8bf75c6d9 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -441,37 +441,14 @@ base::string16 ExtensionInstallPrompt::Prompt::GetPermissionsHeading(
}
base::string16 ExtensionInstallPrompt::Prompt::GetRetainedFilesHeading() const {
- const int kRetainedFilesMessageIDs[6] = {
- IDS_EXTENSION_PROMPT_RETAINED_FILES_DEFAULT,
- IDS_EXTENSION_PROMPT_RETAINED_FILE_SINGULAR,
- IDS_EXTENSION_PROMPT_RETAINED_FILES_ZERO,
- IDS_EXTENSION_PROMPT_RETAINED_FILES_TWO,
- IDS_EXTENSION_PROMPT_RETAINED_FILES_FEW,
- IDS_EXTENSION_PROMPT_RETAINED_FILES_MANY,
- };
- std::vector<int> message_ids(
- kRetainedFilesMessageIDs,
- kRetainedFilesMessageIDs + arraysize(kRetainedFilesMessageIDs));
-
- return l10n_util::GetPluralStringFUTF16(message_ids, GetRetainedFileCount());
+ return l10n_util::GetPluralStringFUTF16(
+ IDS_EXTENSION_PROMPT_RETAINED_FILES, GetRetainedFileCount());
}
base::string16 ExtensionInstallPrompt::Prompt::GetRetainedDevicesHeading()
const {
- const int kRetainedDevicesMessageIDs[6] = {
- IDS_EXTENSION_PROMPT_RETAINED_DEVICES_DEFAULT,
- IDS_EXTENSION_PROMPT_RETAINED_DEVICE_SINGULAR,
- IDS_EXTENSION_PROMPT_RETAINED_DEVICES_ZERO,
- IDS_EXTENSION_PROMPT_RETAINED_DEVICES_TWO,
- IDS_EXTENSION_PROMPT_RETAINED_DEVICES_FEW,
- IDS_EXTENSION_PROMPT_RETAINED_DEVICES_MANY,
- };
- std::vector<int> message_ids(
- kRetainedDevicesMessageIDs,
- kRetainedDevicesMessageIDs + arraysize(kRetainedDevicesMessageIDs));
-
- return l10n_util::GetPluralStringFUTF16(message_ids,
- GetRetainedDeviceCount());
+ return l10n_util::GetPluralStringFUTF16(
+ IDS_EXTENSION_PROMPT_RETAINED_DEVICES, GetRetainedDeviceCount());
}
bool ExtensionInstallPrompt::Prompt::ShouldShowPermissions() const {
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698