chrome/browser/extensions/api/developer_private/extension_info_generator.h - Issue 1049483003: [Extensions] Update extensions UI to observe events and add test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.h

Issue 1049483003: [Extensions] Update extensions UI to observe events and add test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator.cc » ('j') | chrome/browser/resources/extensions/extension_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.h

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.h b/chrome/browser/extensions/api/developer_private/extension_info_generator.h

index 9b50bfb3a55561a311052c543e46280bf5c7a336..736acce7c22ea6789a08178d1d3b75e8e9949c03 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.h

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.h

@@ -27,12 +27,16 @@ class ExtensionInfoGenerator {

explicit ExtensionInfoGenerator(content::BrowserContext* context);

~ExtensionInfoGenerator();

- // Return the ExtensionInfo for a given |extension| and |state|.

+ // Returns the ExtensionInfo for a given |extension| and |state|.

scoped_ptr<api::developer_private::ExtensionInfo> CreateExtensionInfo(

const Extension& extension,

api::developer_private::ExtensionState state);

+ // Returns an ExtensionInfo for the given |extension_id|, if the extension

+ // can be found.

+ scoped_ptr<api::developer_private::ExtensionInfo> CreateExtensionInfo(

+ const std::string& id);

- // Return a collection of ExtensionInfos, optionally including disabled and

+ // Returns a collection of ExtensionInfos, optionally including disabled and

// terminated.

ExtensionInfoList CreateExtensionsInfo(bool include_disabled,

bool include_terminated);