chrome/browser/resources/extensions/extensions.js - Issue 1049483003: [Extensions] Update extensions UI to observe events and add test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 1049483003: [Extensions] Update extensions UI to observe events and add test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/ui/webui/extensions/extension_settings_browsertest.js » ('j') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extensions.js

diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js

index 1eadba3e9c2f6c3ae71f43a665d4527b0dccc7a2..8dee3725d2747abe85b82f27a3625d1ed5266992 100644

--- a/chrome/browser/resources/extensions/extensions.js

+++ b/chrome/browser/resources/extensions/extensions.js

@@ -340,6 +340,7 @@ cr.define('extensions', function() {

instance.displayPromo_ = extensionsData.promoteAppsDevTools;

instance.updateDevControlsVisibility_(false);

+ document.documentElement.classList.add('loading');

Dan Beam 2015/04/07 17:21:13 nit: out of curiosity, why not put this...

Devlin 2015/04/07 21:14:50 Sounds good to me.

$('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;

var extensionList = $('extension-settings-list');

extensionList.updateExtensionsData(

@@ -349,7 +350,6 @@ cr.define('extensions', function() {

// be careful to remove the 'finished loading' timeout.

if (this.loadingTimeout_)

window.clearTimeout(this.loadingTimeout_);

- document.documentElement.classList.add('loading');

this.loadingTimeout_ = window.setTimeout(function() {

document.documentElement.classList.remove('loading');

}, 0);