[Extensions] Update extensions UI to observe events and add test

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/lazy_instance.h"
@@ skipping 133 matching lines @@
 
   return render_view_host->GetSiteInstance()->GetSiteURL().host();
 }
 
 void BroadcastItemStateChanged(content::BrowserContext* browser_context,
                                developer::EventType event_type,
                                const std::string& item_id) {
   developer::EventData event_data;
   event_data.event_type = event_type;
   event_data.item_id = item_id;
+  event_data.extension_info =
+      ExtensionInfoGenerator(browser_context).CreateExtensionInfo(item_id);
 
   scoped_ptr<base::ListValue> args(new base::ListValue());
   args->Append(event_data.ToValue().release());
   scoped_ptr<Event> event(new Event(
       developer_private::OnItemStateChanged::kEventName, args.Pass()));
   EventRouter::Get(browser_context)->BroadcastEvent(event.Pass());
 }
 
 std::string ReadFileToString(const base::FilePath& path) {
   std::string data;
@@ skipping 236 matching lines @@
 DeveloperPrivateGetExtensionInfoFunction::
 ~DeveloperPrivateGetExtensionInfoFunction() {
 }
 
 ExtensionFunction::ResponseAction
 DeveloperPrivateGetExtensionInfoFunction::Run() {
   scoped_ptr<developer::GetExtensionInfo::Params> params(
       developer::GetExtensionInfo::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
-  ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
-  developer::ExtensionState state = developer::EXTENSION_STATE_ENABLED;
-  const Extension* extension =
-      registry->enabled_extensions().GetByID(params->id);
-  if (!extension &&
-      (extension = registry->disabled_extensions().GetByID(params->id)) !=
-          nullptr) {
-    state = developer::EXTENSION_STATE_DISABLED;
-  } else if (!extension &&
-             (extension =
-                  registry->terminated_extensions().GetByID(params->id)) !=
-                  nullptr) {
-    state = developer::EXTENSION_STATE_TERMINATED;
-  }
+  scoped_ptr<developer::ExtensionInfo> info =
+    ExtensionInfoGenerator(browser_context()).CreateExtensionInfo(params->id);

[Dan Beam, 2015/04/06 23:53:11]

+\s\s

[Devlin, 2015/04/07 16:07:54]

Done.

 
-  if (!extension)
+  if (!info)

[Dan Beam, 2015/04/06 23:53:12]

how is info ever empty?
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[Devlin, 2015/04/07 16:07:54]

Two methods. One takes a const Extension& (resultant info is never empty), one
takes an id (resultant info is empty iff an extension with |id| cannot be
found).

[Dan Beam, 2015/04/07 17:21:13]

yeah, sorry, found the answer but didn't delete comment

     return RespondNow(Error(kNoSuchExtensionError));
 
-  return RespondNow(OneArgument(ExtensionInfoGenerator(browser_context()).
-      CreateExtensionInfo(*extension, state)->ToValue().release()));
+  return RespondNow(OneArgument(info->ToValue().release()));
 }
 
 DeveloperPrivateGetItemsInfoFunction::DeveloperPrivateGetItemsInfoFunction() {}
 DeveloperPrivateGetItemsInfoFunction::~DeveloperPrivateGetItemsInfoFunction() {}
 
 ExtensionFunction::ResponseAction DeveloperPrivateGetItemsInfoFunction::Run() {
   scoped_ptr<developer::GetItemsInfo::Params> params(
       developer::GetItemsInfo::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
@@ skipping 785 matching lines @@
   }
   error_console->RemoveErrors(ErrorMap::Filter(
       properties.extension_id, type, error_ids, false));
 
   return RespondNow(NoArguments());
 }
 
 }  // namespace api
 
 }  // namespace extensions