[Extensions] Update extensions UI to observe events and add test

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 38 matching lines @@
   assertEquals(this.browsePreload, document.location.href);
 
   // This dialog should be hidden at first.
   assertFalse($('pack-extension-overlay').classList.contains('showing'));
 
   // Show the dialog, which triggers a chrome.send() for metrics purposes.
   cr.dispatchSimpleEvent($('pack-extension'), 'click');
   assertTrue($('pack-extension-overlay').classList.contains('showing'));
 });
 
+function BasicExtensionSettingsWebUITest() {}
+
+BasicExtensionSettingsWebUITest.prototype = {
+  __proto__: ExtensionSettingsWebUITest.prototype,
+
+  /** @override */
+  isAsync: true,
+
+  /** @override */
+  testGenPreamble: function() {
+    // Install multiple types of extensions to ensure we handle each type.
+    // TODO(devlin): There are more types to add here.
+    GEN('  InstallGoodExtension();');
+    GEN('  InstallErrorsExtension();');
+    GEN('  InstallSharedModule();');
+    GEN('  InstallPackagedApp();');

[Dan Beam, 2015/04/02 01:34:54]

why do we need to install all types for this test?

[Devlin, 2015/04/02 21:50:05]

It's not so much that we need all types for any of these specific tests so much
as we've had some bugs where we encounter errors just because we never test for
having an extension type x loaded (e.g., never having a shared module).  I
figured that it wasn't really worth having a dedicated test to
"LoadABunchOfExtensionTypes" and do nothing when we could just do that as part
of these tests, but I don't feel strongly about how it's organized (just as long
as we *do* have at least one test that loads these extension types).

+
+    GEN('  SetAutoConfirmUninstall();');
+  },
+
+  /** @protected {Array<!Function>} */
+  steps: [],
+
+  /** @protected */
+  nextStep: function() {
+    assertTrue(this.steps.length > 0);
+    this.steps.shift().bind(this)();
+  },
+
+  /** @protected */
+  waitForPageLoad: function() {
+    extensionList = $('extension-settings-list');
+    extensionList.extensionsUpdated.then(this.nextStep.bind(this));
+  },
+
+  /** @protected */
+  verifyDisabledWorks: function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, false, function() {
+      var node = $(GOOD_CRX_ID);
+      assertTrue(node != null);
+      assertTrue(node.classList.contains('inactive-extension'));
+      this.nextStep();
+    }.bind(this));
+  },
+
+  /** @protected */
+  verifyEnabledWorks: function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, true, function() {
+      var node = $(GOOD_CRX_ID);
+      assertTrue(node != null);
+      assertFalse(node.classList.contains('inactive-extension'));
+      this.nextStep();
+    }.bind(this));
+  },
+
+  /** @protected */
+  verifyUninstallWorks: function() {
+    var next = this.nextStep.bind(this);
+    chrome.test.runWithUserGesture(function() {
+      chrome.management.uninstall(GOOD_CRX_ID, function() {
+        assertTrue($(GOOD_CRX_ID) == null);

[Dan Beam, 2015/04/02 01:34:54]

assertEQ(null, $(GOOD_CRX_ID))

or

assertFalse($(GOOD_CRX_ID))

[Devlin, 2015/04/02 21:50:05]

Done.

+        next();
+      });
+    });
+  },
+};
+
+TEST_F('BasicExtensionSettingsWebUITest', 'testDisable', function() {
+  this.steps = [this.waitForPageLoad,
+                this.verifyDisabledWorks,
+                testDone];
+  this.nextStep();
+});
+
+TEST_F('BasicExtensionSettingsWebUITest', 'testEnable', function() {
+  var disable = function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, false, function() {

[Dan Beam, 2015/04/02 01:34:54]

, this.nextStep.bind(this));

[Devlin, 2015/04/02 21:50:05]

Obselete.

+      this.nextStep();
+    }.bind(this));
+  }.bind(this);
+  this.steps = [this.waitForPageLoad,
+                disable,

[Dan Beam, 2015/04/02 01:34:54]

can't this just be this.verifyDisableWorks in this case?  seems pretty similar.

i didn't know you have to disable to test that enable works.

[Devlin, 2015/04/02 21:50:05]

Yeah, can be - wasn't sure if that was too much overlap between the two tests
(since that means if disable fails, both will fail).  Changed.

+                this.verifyEnabledWorks,
+                testDone];
+  this.nextStep();
+});
+
+TEST_F('BasicExtensionSettingsWebUITest', 'testUninstall', function() {
+  this.steps = [this.waitForPageLoad,
+                this.verifyUninstallWorks,
+                testDone];
+  this.nextStep();
+});
+
 function AsyncExtensionSettingsWebUITest() {}
 
 AsyncExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   isAsync: true,
 
   /** @override */
   testGenPreamble: function() {
@@ skipping 157 matching lines @@
 
 ExtensionOptionsDialogWebUITest.prototype = {
   __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('ExtensionOptionsDialogWebUITest', 'testAccessibility', runAudit);