[Extensions] Update extensions UI to observe events and add test

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 38 matching lines @@
   assertEquals(this.browsePreload, document.location.href);
 
   // This dialog should be hidden at first.
   assertFalse($('pack-extension-overlay').classList.contains('showing'));
 
   // Show the dialog, which triggers a chrome.send() for metrics purposes.
   cr.dispatchSimpleEvent($('pack-extension'), 'click');
   assertTrue($('pack-extension-overlay').classList.contains('showing'));
 });
 
+function BasicExtensionSettingsWebUITest() {}
+
+BasicExtensionSettingsWebUITest.prototype = {
+  __proto__: ExtensionSettingsWebUITest.prototype,
+
+  /** @override */
+  isAsync: true,
+
+  /** @override */
+  testGenPreamble: function() {
+    // Install different types of extensions to try and exercise as many code
+    // paths as possible.

[Dan Beam, 2015/04/01 23:12:04]

this generally sounds like a recipe for flakiness.

you should break this up into like 3 different tests

[Devlin, 2015/04/02 00:01:39]

Fair enough.  I try to avoid it when possible, because browser tests are so
expensive, but it probably is too much here.  You okay with leaving all the
functionality in this class?  I personally find it a bit more readable, but
that's just me.

+    // TODO(devlin): There are more types to add here.
+    GEN('  InstallGoodExtension();');
+    GEN('  InstallErrorsExtension();');
+    GEN('  InstallSharedModule();');
+
+    GEN('  SetAutoConfirmUninstall();');
+  },
+

[Dan Beam, 2015/04/01 23:12:04]

/** @protected {Array<!Function>} */

[Devlin, 2015/04/02 00:01:38]

Done.

+  steps: [],
+

[Dan Beam, 2015/04/01 23:12:04]

all these should be @protected

[Devlin, 2015/04/02 00:01:39]

Done.

+  nextStep: function() {
+    assertTrue(this.steps.length > 0);
+    this.steps.shift().bind(this)();
+  },
+
+  waitForPageLoad: function() {
+    extensionList = $('extension-settings-list');
+    extensionList.extensionsUpdated.then(this.nextStep.bind(this));
+  },
+
+  verifyDisabledWorks: function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, false, function() {
+      var node = $(GOOD_CRX_ID);
+      assertTrue(node != null);
+      assertTrue(node.classList.contains('inactive-extension'));
+      this.nextStep();
+    }.bind(this));
+  },
+
+  verifyEnabledWorks: function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, true, function() {
+      var node = $(GOOD_CRX_ID);
+      assertTrue(node != null);
+      assertFalse(node.classList.contains('inactive-extension'));
+      this.nextStep();
+    }.bind(this));
+  },
+
+  verifyUninstallWorks: function() {
+    var next = this.nextStep.bind(this);
+    chrome.test.runWithUserGesture(function() {
+      chrome.management.uninstall(GOOD_CRX_ID, function() {
+        assertTrue($(GOOD_CRX_ID) == null);
+        next();
+      });
+    });
+  },
+};
+
+TEST_F('BasicExtensionSettingsWebUITest', 'testBasic', function() {
+  this.steps = [this.waitForPageLoad,
+                this.verifyDisabledWorks,
+                this.verifyEnabledWorks,
+                this.verifyUninstallWorks,
+                testDone];
+  this.nextStep();
+});
+
 function AsyncExtensionSettingsWebUITest() {}
 
 AsyncExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   isAsync: true,
 
   /** @override */
   testGenPreamble: function() {
@@ skipping 157 matching lines @@
 
 ExtensionOptionsDialogWebUITest.prototype = {
   __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('ExtensionOptionsDialogWebUITest', 'testAccessibility', runAudit);